Pull request

A pull request under review, composed from the system and nothing else. The merge is the one key action on the screen; everything else is a secondary control or a fact about the change.

Light

fjord-os/repo-web

feat/accounts-s1-logininto main

accounts: fjord-web login, read-only

#41

author: stephen
opened: 2026-07-29
commits: 3
changed: 2 files, +5 -1

Checks4

test lint deploy notify

Conversation3

stephenopened 2026-07-29

The login slice is deliberately read-only. It establishes a session and a signed-in identity, and it stops there: no write path reaches the daemon, and no route added in this change mutates anything.

The cookie work lives in src/app.rs. See e6d13d5 for the header change.

fjordchecks completed

review requested from avery

averyreviewed 12 minutes ago

Approving. One question on the import order below, which does not block: would RouterBuilderCookieExt read better next to the router imports it extends?

Files changed1

Modifiedsrc/app.rs+5 -1

@@ -15,8 +15,12 @@ one place. `discover()` collects them either way1515 16+pub mod login;1617 pub mod r;1718 1819 use topcoat::{20+    cookie::RouterBuilderCookieExt,1921     router::{20-        error::NotFoundError, layout, page, Router, StatusCode,22+        error::NotFoundError,23+        header::{CACHE_CONTROL, VARY},24+        layout, page, HeaderValue, Router, StatusCode,2125     },

Reply

Comment

Markdown. A sha, a path or a ref stays in mono.

Dark